https://bugzilla.redhat.com/show_bug.cgi?id=1393021 Jason Taylor <jtfas90@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Jason Taylor <jtfas90@xxxxxxxxx> --- Hi Marcin, A couple of items: 1. LICENSE should be tagged as %license under %files. It is currently listed as %doc in the spec 2. It might be worth getting licensing clarification on contrib/oink-conv.pl. Either include a GPL2 header as pulledpork.pl does or similar indicator. 3. The spec as written does not define ownership of the /etc/pulledpork directory 4. The spec as written does not define ownership of /usr/share/pulledpork 5. Take a look at https://fedoraproject.org/wiki/Packaging:Perl for additional items related to packaging perl. Thanks! JT -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx