https://bugzilla.redhat.com/show_bug.cgi?id=1392649 --- Comment #2 from Philip Prindeville <philipp@xxxxxxxxxxxxxxxxxxxxx> --- Here's the output from rpmlint on both files: tacacs+.src: W: invalid-url Source0: tacacs-F4.0.4.29a.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL. tacacs+.x86_64: W: no-manual-page-for-binary tac_convert Each executable in standard binary directories should have a man page. tacacs+.x86_64: W: service-default-enabled /etc/rc.d/init.d/tac_plus The service is enabled by default after "chkconfig --add"; for security reasons, most services should not be. Use "-" as the default runlevel in the init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword to fix this if appropriate for this service. tacacs+.x86_64: W: incoherent-init-script-name tac_plus ('tacacs+', 'tacacs+d') The init script name should be the same as the package name in lower case, or one with 'd' appended if it invokes a process by that name. 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Yes, the Source: value will need to be updated. When the reviews are done and I commit a final version of the .spec file to github, I will tag and publish a tarball which agrees with what's in the final .spec file. There is no man page for tac_convert, but tac_convert is a Perl script. Use the source, Luke! Regarding the init.d file... not sure if I should mangle it with a sed script to replace "chkconfig: 2345" with "chkconfig: -" or leave it as is but explicitly disable it with "chkconfig tac_plus off" in the %post. Incoherent script name... again, trying to preserve the sources wherever possible. This is what it was called upstream. Don't want to diverge too much from that. Plus it will likely have a ripple effect: the daemon name will change to agree with the init.d script name, then the config file for the daemon will need to change too, then the man page for the config file needs to change... It snowballs. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx