[Bug 1392606] Review Request: perl-Encode-IMAPUTF7 - Process the special UTF-7 variant required by IMAP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1392606



--- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Encode-IMAPUTF7-1.05-1.fc26.noarch.rpm | sort | uniq
-c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Most of binary requires are missing, because perl-generators was not
installed.

$ rpm -qp --provides perl-Encode-IMAPUTF7-1.05-1.fc26.noarch.rpm | sort | uniq
-c
      1 perl-Encode-IMAPUTF7 = 1.05-1.fc26
FIX: Provides 'erl(Encode::IMAPUTF7) = 1.05 is not listed due to missing
perl-generators

$ rpmlint ./perl-Encode-IMAPUTF7*
perl-Encode-IMAPUTF7.src: W: strange-permission Encode-IMAPUTF7-1.05.tar.gz 660
perl-Encode-IMAPUTF7.src: W: strange-permission perl-Encode-IMAPUTF7.spec 660
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Rpmlint is ok

BuildRequires:
FIX: Please add following build-requires:
    coreutils - because 'tr', 'mv', 'touch',... are used in spec file
    findutils - 'find' is used in spec file
    perl - it is used in spec file
    perl-generators - is necessary for generating of package provides and
                      requires. The package is not part of default
              buildroot
    Encode-IMAPUTF7-1.05/Makefile.PL
    perl(base) - lib/Encode/IMAPUTF7.pm:7
    perl(Encode::Encoding) - lib/Encode/IMAPUTF7.pm:7
    perl(File::Basename) - t/0-test.t:12
    perl(File::Spec) - t/0-test.t:13
    perl(MIME::Base64) - lib/Encode/IMAPUTF7.pm:10
    perl(strict) - lib/Encode/IMAPUTF7.pm:5
    perl(Test::More) - t/0-test.t:12
    perl(warnings) - lib/Encode/IMAPUTF7.pm:7

TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR.

If you want to add the package to EPEL, please ignore these two TODO 
TODO: The easier way to remove .packlist is used NO_PACKLIST option,
      which is part of perl(ExtUtils::MakeMaker) >= 6.76. It can be 
      used in all Fedoras. The command is 
      %{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1

TODO: Remove the deleting empty directories in %install section. This is
      default behavior for Fedoras.


Please correct all 'FIX' issues and consider fixing 'TODO' items and
provide new spec file.

The package is not approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]