https://bugzilla.redhat.com/show_bug.cgi?id=1343977 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |asciidoctor-mallard - A |rubygem-asciidoctor-mallard |Project Mallard converter |- A Project Mallard |for AsciiDoc |converter for AsciiDoc --- Comment #9 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Source of the gem? - Where did you get the source gem? It is not available on rubygems.org as far as I can tell, neither you documented anywhere how you obtained it. * Package naming - Please rename the .spec file to rubygem-asciidoctor-mallar.spec to be in line with the guidelines [1]. * Package version - Please use proper version scheme. The package version should be probably just "0.1.0" while the release should be "0.1.dev". - The versioning is documented in detail here [2]. * Duplicated license - You should not include the "%license LICENSE.adoc". Please keep just "%doc %{gem_instdir}/LICENSE.adoc" in the main package (and change the %doc to %license of course). * Unneeded requires - You probably don't need to include "Requires: rubygem-thread_safe". Runtime requires should be autogenerated during build process. - Not sure what is the "pintail" good for. Some explaining hint above would come handy. * Doc subpackage - It is good habit to keep the documentation in -doc subpackage. * Test suite - Well, the line you used is just part of the story. You can see that there is nothing which would indicated, that the test suite was executed. You should use following line: ``` ruby -Ilib -e 'Dir.glob "./test/*_test.rb", &method(:require)' ``` - Unfortunately, there seems to be dependency on asciidoctor-doctest, which is not in Fedora yet. Since it has quite lot of dependencies, it is probably not worth of packaging ATM, but all this should be documented. - Instead of execution of test suite, you should consider to provide at least some sanity test, e.g. try to convert some document from AsciiDoc to Mallard using the %{gem_instdir}/bin/asciidoctor-mallard * Bump release between review iteration - It is good habit to bump the package release each review iteration. [1] https://fedoraproject.org/wiki/Packaging:Ruby#Naming_Guidelines [2] https://fedoraproject.org/wiki/Packaging:Versioning#Pre-Release_packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
