https://bugzilla.redhat.com/show_bug.cgi?id=1324636 Tim Orling <TicoTimo@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Tim Orling <TicoTimo@xxxxxxxxx> --- Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16344573 Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package contains BR: python2-devel or python3-devel => This is ok, as %{python3_pkgversion}-devel is used and this is EPEL only. - Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools => This is ok, as 'autoupdate' is used in spec file to replace obsolete macros ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. => expected behavior for python extensions, *.so -> site-packages [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 10 files have unknown license. Detailed output of licensecheck in /home/parallels/1324636-python3-dbus/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/licenses => EPEL7 has no owner of /usr/share/licenses [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/licenses [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: python34-dbus (summary), python34-dbus (description) [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools => spec uses Autoupdate which fixes this [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python34-dbus-1.2.4-2.el7.centos.x86_64.rpm python3-dbus-1.2.4-2.el7.centos.src.rpm python34-dbus.x86_64: W: no-documentation => nothing useful provided by package. building pydocs does not make sense. python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/mainloop/__pycache__/glib.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/server.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/gi_service.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/decorators.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/decorators.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/mainloop/__pycache__/glib.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/lowlevel.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/exceptions.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/_expat_introspect_parser.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/types.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/_expat_introspect_parser.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/types.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/exceptions.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/glib.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/mainloop/__pycache__/__init__.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/service.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/gi_service.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/service.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/glib.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/mainloop/__pycache__/__init__.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/proxies.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/proxies.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/bus.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/connection.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/__init__.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/server.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/__init__.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/bus.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/connection.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/_compat.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/_compat.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/lowlevel.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/_dbus.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/_dbus.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) => These are a from a bug in rpmlint: https://lists.opensuse.org/opensuse-bugs/2014-05/msg00374.html python3-dbus.src:42: W: configure-without-libdir-spec => normal behavior for python extensions, .so -> site-packages 2 packages and 0 specfiles checked; 34 errors, 2 warnings. Rpmlint (debuginfo) ------------------- Checking: python3-dbus-debuginfo-1.2.4-2.el7.centos.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- python3-dbus-debuginfo.x86_64: W: only-non-binary-in-usr-lib python34-dbus.x86_64: W: no-documentation python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/mainloop/__pycache__/glib.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/server.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/gi_service.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/decorators.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/decorators.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/mainloop/__pycache__/glib.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/lowlevel.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/exceptions.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/_expat_introspect_parser.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/types.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/_expat_introspect_parser.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/types.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/exceptions.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/glib.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/mainloop/__pycache__/__init__.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/service.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/gi_service.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/service.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/glib.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/mainloop/__pycache__/__init__.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/proxies.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/proxies.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/bus.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/connection.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/__init__.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/server.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/__init__.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/bus.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/connection.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/_compat.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/_compat.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/lowlevel.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/_dbus.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-dbus.x86_64: E: python-bytecode-wrong-magic-value /usr/lib64/python3.4/site-packages/dbus/__pycache__/_dbus.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) 2 packages and 0 specfiles checked; 34 errors, 2 warnings. Requires -------- python34-dbus (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) python(abi) rtld(GNU_HASH) Provides -------- python34-dbus: python34-dbus python34-dbus(x86-64) Unversioned so-files -------------------- python34-dbus: /usr/lib64/python3.4/site-packages/_dbus_bindings.so python34-dbus: /usr/lib64/python3.4/site-packages/_dbus_glib_bindings.so Source checksums ---------------- http://dbus.freedesktop.org/releases/dbus-python/dbus-python-1.2.4.tar.gz : CHECKSUM(SHA256) this package : e2f1d6871f74fba23652e51d10873e54f71adab0525833c19bad9e99b1b2f9cc CHECKSUM(SHA256) upstream package : e2f1d6871f74fba23652e51d10873e54f71adab0525833c19bad9e99b1b2f9cc http://dbus.freedesktop.org/releases/dbus-python/dbus-python-1.2.4.tar.gz.asc : CHECKSUM(SHA256) this package : ec82aa5f7c5ca0cae2dffa85c7617c2db0791739279c46adc3229e0ee2e56093 CHECKSUM(SHA256) upstream package : ec82aa5f7c5ca0cae2dffa85c7617c2db0791739279c46adc3229e0ee2e56093 AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: dbus-python-1.2.4/configure.ac:58 Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -b 1324636 Buildroot used: epel-7-x86_64 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 =========== All issues have been properly addressed and other flagged issues are not applicable. ** APPROVED ** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx