https://bugzilla.redhat.com/show_bug.cgi?id=1392089 --- Comment #1 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> --- Would you use the template on https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file? It would really improve readability with all those macros set there. As pointed in https://fedoraproject.org/wiki/Packaging:Python#Reviewer_checklist , %python_provide macro must be used. Are there any reasons for not running upstream's test suite under %check? I see there's one here https://github.com/jstasiak/python-zeroconf/blob/master/test_zeroconf.py Also, are there any reasons for not including the README file under %doc? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx