[Bug 1391457] Review Request: python-netjsonconfig - PaNetwork configuration management library based on NetJSON DeviceConfiguration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1391457



--- Comment #10 from Charalampos Stratakis <cstratak@xxxxxxxxxx> ---
When testing the python2 subpackage I stumbled upon some tracebacks

The python2 subpackage should have a runtime requirement for python-ipaddress
module because of:
ImportError: No module named ipaddress

Also there should be a runtime requirement for python-setuptools for epel7 due
to:
ImportError: No module named pkg_resources

The python3_pkgversion macro can be used for the packages that actually use it
on their own (like python-six), thus providing that name, but not every package
uses it, so whenever you have it in you own SPEC you should check each
dependency that they actually utilize this macro at their own SPEC's.

Currently, while it can be built, it is not possible to install the python3
subpackage for epel7 as there is no python3-jinja2 and python3-jsonschema
packages for epel7.

I would suggest contacting either ttorling or orion, as they are quite active
and aware as well, of the current situation in EPEL, so they might be able to
build these dependencies or move some things, in order for your package to be
accepted, although the package review would be stalled until this situation is
resolved.

Another possibility would be to not consider EPEL7 for the time being, and try
to resolve the situation in the future, in order to make your package working
for EPEL7, so for now the review/builds/branches will be only for Fedora.

On another notice, it would be better (but not mandatory) to do some stylistic
changes so the SPEC file is more readable.

An empty line should exist between each subpackage and its respective
description like in the example SPEC [0].

Also (this is more of a personal preference), the Requires as well as the
BuildRequires for each subpackage can be placed between the summary and the
python provide macro. 

[0] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]