https://bugzilla.redhat.com/show_bug.cgi?id=1391892 --- Comment #2 from Javier Peña <jpena@xxxxxxxxxx> --- Hi Matthias, I have some small issues with the current spec file: - The bash-completion subpkg needs to include a license file, since it could be installed independently of the client package. - The python2 and python3 packages include all binaries currently (vitrage, vitrage-3 and vitrage-3.5). - As a nitpick, there's a typo in the summary (Virage vs Vitrage) - Finally, I'd prefer python2 dependencies to be specified as python-* instead of python2-*. This makes it simpler when the spec file is imported by CentOS, which doesn't have python3 subpackages yet. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx