Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: naturette - An AGI adventure game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247775 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-07-11 13:13 EST ------- Builds OK, installs and plays fine. rpmlint says: E: naturette zero-length /usr/share/naturette/snddir which is normal for AGI games which don't include sound. * source files manually compared with upstream. * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is acceptable for content. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: naturette = 1.3-1.fc8 = /bin/bash /bin/sh hicolor-icon-theme nagi * %check is not present; no upstream test suite. Seems fine with manual testing. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * desktop file looks OK and installs without errors. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review