https://bugzilla.redhat.com/show_bug.cgi?id=1370064 --- Comment #11 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> --- Hi Daniel, The -debuginfo subpackage looks good now. Removing the third_party directory is enough for the compiler-rt library, as we can see in [1], since it is licensed under the MIT License. I was in doubt about the .o files, so I did some research here: I am aware of [2], as you pointed out, and it is also worth saying that you are supposed to "Ask upstream to remove the binaries in their next release." (that is pointed as a 'must' in [2]. The .o files (see [3]) are part of Apple's CrashWrangler, which can be downloaded in [4]. I downloaded the sources to check the license for those files and the only license text we have is in the project's README.txt [5], which reads: "Aside from CrashReport_*.o, which contain proprietary code for creating crash logs"... In this case, I believe the .o files in question contain proprietary software and should not be included, even in the tarball. Would you generate a new tarball, as pointed out in [6]? Other than that the package seems good to me and provided the new tarball, I believe the review would be done. It would also be nice to ask upstream to remove the .o files from the sources, since I am not even sure if they can be redistributed at all. [1] https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries#Treatment_of_Bundled_Libraries [2] https://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-built_binaries_or_libraries [3] https://github.com/google/honggfuzz/tree/master/third_party/mac [4] https://developer.apple.com/library/content/technotes/tn2334/_index.html [5] http://paste.fedoraproject.org/468199/10519214/ [6] https://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohibited_Code -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx