https://bugzilla.redhat.com/show_bug.cgi?id=1376848 Björn "besser82" Esser <fedora@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(fedora@besser82.i | |o) | --- Comment #5 from Björn "besser82" Esser <fedora@xxxxxxxxxxx> --- (In reply to Daniel Pocock from comment #4) > Björn, thanks for reviewing this spec file > > I'm happy to make these changes, but will all of these things be compatible > with RHEL7 / EPEL7 as well? I'm hoping to use the same spec file for both > Fedora and EPEL RPMs. > > If some of the changes are not good for RHEL7/EPEL builds, are they > essential for Fedora? You're welcome. Those changes would be the same for EPEL7; there is no need to have some conditionals-magic for my suggeseted changes. BuildRequires on auto(conf|make) and libtool are needed on any release of Fedora or EPEL, those `%make_*`-macros are available on EPEL >= 6, using systemd-macros is mandatory starting with EPEL7 [1], %autosetup works with all maintained releases of Fedora and EPEL (with a little exception on EPEL5 [2]), `%license` translates to `%doc` on EPEL <= 6 [3] and changes for github-style source packaging works fine for Fedora and EPEL >= 5. For EPEL <= 6 the might apply some other conditional changes [4] not needed for Fedora or EPEL >= 7. [1] https://fedoraproject.org/wiki/EPEL:SysVInitScript#EPEL_SysV_Initscripts [2] https://fedoraproject.org/wiki/EPEL:Packaging#.25autosetup [3] https://fedoraproject.org/wiki/EPEL:Packaging#Previously_required_boilerplate [4] https://fedoraproject.org/wiki/EPEL:Packaging -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx