[Bug 1389016] Review Request: libxsmm - Library for small matrix-matrix multiplications on Intel x86_64 (e.g. for cp2k)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1389016



--- Comment #15 from Hans Pabst <hans.pabst@xxxxxxxxx> ---
One more comment about the OMP build key. It's actually a "tristate":
(1) OMP=1: default (note: -fopenmp [or equivalent] only applies to libxsmmext)
(2) OMP=0: non-default, turns OpenMP off (even for libxsmmext!)
(3) OMP build key is not specified -> similar to #1
I recommend to stay with #3.

Other comments about the build specification:
- STATIC=0: that's fine if you want shared libraries. Btw, you can build static
libraries in addition if needed.
- PREFETCH=1: superfluous, it's the default anyways (CPUID-based prefetch
strategy).
- SYM=1: non-default but just fine (if symbols are needed/policy).
- SSE=0: turns generating SSE3 instructions off; fine if that's the policy.
Regarding the latter, in particular critical code is CPUID-dispatched e.g.,
using CRC32 instruction/s (SSE4.2) for the JIT-code registry.

One more comment regarding the package warnings: .make files are indeed empty,
those are build artifacts and do not need to be packaged. The spelling of
"coprocessor" (as opposed to co-processor) is intentionally wrt to KNC.
Regarding the "spurious-executable-perm", i may rename these scripts to .sh if
that helps (though this sample needs to be scrubbed a bit anyways ;-).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]