https://bugzilla.redhat.com/show_bug.cgi?id=1388294 --- Comment #10 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Evan Klitzke from comment #8) > Hi Zbigniew and Filip, > > I made some changes, and I have a few questions. > > Updated spec: https://eklitzke.org/pyflame.spec > Updated SRPM: https://eklitzke.org/pyflame-1.1.1-1.fc25.src.rpm > > This addresses all of the feedback except the Py3 stuff, which I have a > question about. > > Question: currently Pyflame requires building against either Python 2, or > Python 3. It actually does *not* link against libpython, but it does use the > struct definitions from Python.h to know the struct offsets of various > Python fields, and right now you can only build against one or the other. I > think I might be able to do some stuff upstream to make it possible to build > against both simultaneously, but I'm not sure how much work that will be. > What do you think the best option is here? Supporting both simultaneously would of course be best. But for now, the solution would be to build two binary packages to support both versions of python. https://fedoraproject.org/wiki/Packaging:Python#Naming has some explanations, but unfortunately it also contains a lot of noise. Essentially, you want a layout with a bunch of symlinks like this: [python3-pyflame] /usr/bin/pyflame → pyflame-3 /usr/bin/pyflame-3 → pyflame-3.5 /usr/bin/pyflame-3.5 [python2-pyflame] /usr/bin/pyflame-2 → pyflame-2.7 /usr/bin/pyflame-2.7 (E.g. see pytohn2-pytest and python3-pytest packages for an example.) So your package would BR: python2-devel, BR: python3-devel, and similarly for other build dependencies. (In reply to Evan Klitzke from comment #9) > One more question: is there a way to specify test dependencies separately? > The tests for this package require python-pytest to be installed, but it's > not *actually* a build dependency. I don't know. If the tests require it, and the tests get run during build, then it *is* a build dependency. We don't really optimize build dependencies, one or two small packages are not noticeable. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx