https://bugzilla.redhat.com/show_bug.cgi?id=1388294 --- Comment #8 from Evan Klitzke <evan@xxxxxxxxxxxx> --- Hi Zbigniew and Filip, I made some changes, and I have a few questions. Updated spec: https://eklitzke.org/pyflame.spec Updated SRPM: https://eklitzke.org/pyflame-1.1.1-1.fc25.src.rpm This addresses all of the feedback except the Py3 stuff, which I have a question about. Question: currently Pyflame requires building against either Python 2, or Python 3. It actually does *not* link against libpython, but it does use the struct definitions from Python.h to know the struct offsets of various Python fields, and right now you can only build against one or the other. I think I might be able to do some stuff upstream to make it possible to build against both simultaneously, but I'm not sure how much work that will be. What do you think the best option is here? I will start reviewing some other Python packages. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx