[Bug 1388294] Review Request: pyflame -- A Ptracing Profiler For Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1388294

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zbyszek@xxxxxxxxx
             Blocks|177841 (FE-NEEDSPONSOR)     |



--- Comment #6 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
%description should be augmented: what is good for? Why is better than the
competition? Etc. The description you gave on the mailing list would be a good
start.

New Python packages SHOULD support/use python3. Does pyflame support python3.5?
If yes, you should switch to it. (I'm assuming that one version works equally
well to analyze both python2 and python3 scripts... Actually it'd be good to
mention that in the %description too: "This package supports Python 2 and
Python 3" ?)

You must include the license file in the binary package
[https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text].

You have tests. They SHOULD be run in %check.

README.md should be packaged as %doc.


I can sponsor you into the packagers group. In addition to the package that you
are submitting, I require two-three real reviews of other packages (see
http://fedoraproject.org/PackageReviewStatus/NEW.html). There's plenty of
python packages awaiting review, so you should be able to find something
interesting without any trouble. In your review, please indicate that you are
not a packager yet, hence the review is unofficial. If nobody beats you to it,
you'll be able to finalize those reviews after you become a packager (hopefully
soon ;)). Running fedora-review and carefully looking at the output is a good
start.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]