https://bugzilla.redhat.com/show_bug.cgi?id=1303349 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx --- Comment #9 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Link Dupont from comment #5) > [-]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in > flyingsaucersattack-debuginfo Just a note: this requirement is not applicable for -debuginfo packages, in fact it is fine to mix&match debuginfo packages. fedora-review should learn to not say that. > [ ]: Package should compile and build into binary rpms on all supported > architectures. There's a koji build link above... so this is also satisfied. Group tag is obsolete [https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections]. %description should be wrapped to 72-80 columns. Also, conventionally, one would use a space here: "F.S.A. (Flying Saucers Attack)" ^ Some suggestions for brevity: %setup -q -n fuga120h %patch0 -p1 -b .unix for i in docs/*; do sed -i 's/\r//' $i; done ↓ %autosetup -n fuga120h -p1 sed -i 's/\r//' docs/* make %{?_smp_mflags} ... → %make_build ... make -C sources install DESTDIR=$RPM_BUILD_ROOT → %make_install -C sources mkdir -p $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/64x64/apps install -p -m 644 %{SOURCE1} \ $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/64x64/apps/ → install -D -p -m 644 -t %{buildroot}%{_datadir}/icons/hicolor/64x64/apps/ ${SOURCE1} etc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx