https://bugzilla.redhat.com/show_bug.cgi?id=1379432 --- Comment #7 from Alec Leamas <leamas.alec@xxxxxxxxx> --- Hm... note that the bundling guidelines have changed [1], bottom line is that you are not required to unbundle if the bundled code isn't packaged already. For example, I'd think twice before unbundling some of this python code. The alternative is to bundle it properly with a virtual Provides: etc. >From a review standpoint I'm mostly concerned with the fonts and large, standard javascript libraries such as jquery and react; I think these should unbundled. I'm also surprised that the installation code doesn't minify the javascript libs. Here are examples of react (again) which is 650k, this is a lot to download in a webpage. It should be minified in production, preferably in a patch which could be upstreamed. The proper solution would be to use some bundling tool like webpack or so, but this is probably beyond the scope of packaging. I'm also concerned with the licenses. The list produced by fedora-review is a good starter for a working license break-down. [1] https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx