https://bugzilla.redhat.com/show_bug.cgi?id=1382922 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-WWW-Form-UrlEncoded.spec.old 2016-10-08 13:26:44.000000000 +0200 +++ perl-WWW-Form-UrlEncoded.spec 2016-10-23 17:49:39.000000000 +0200 @@ -1,6 +1,6 @@ Name: perl-WWW-Form-UrlEncoded Version: 0.23 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Parser and builder for application/x-www-form-urlencoded License: GPL+ or Artistic URL: http://search.cpan.org/dist/WWW-Form-UrlEncoded/ @@ -13,15 +13,20 @@ BuildRequires: perl-generators BuildRequires: perl >= 0:5.008001 + BuildRequires: perl(Exporter) +BuildRequires: perl(File::Basename) +BuildRequires: perl(File::Copy) +BuildRequires: perl(File::Spec) BuildRequires: perl(JSON) >= 2 BuildRequires: perl(Module::Build) > 0.38 BuildRequires: perl(Test::More) >= 0.98 + +BuildRequires: perl(base) +BuildRequires: perl(bytes) BuildRequires: perl(strict) -BuildRequires: perl(warnings) BuildRequires: perl(utf8) -BuildRequires: perl(File::Basename) -BuildRequires: perl(File::Spec) +BuildRequires: perl(warnings) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) @@ -52,5 +57,8 @@ %{_mandir}/man3/* %changelog +* Sat Oct 22 2016 Ralf Corsépius <corsepiu@xxxxxxxxxxxxxxxxx> - 0.23-2 +- Reflect feedback from review. + * Sat Oct 08 2016 Ralf Corsépius <corsepiu@xxxxxxxxxxxxxxxxx> - 0.23-1 - Initial Fedora packages. > FIX: Build-require `perl(File::Copy)' (Build.PL:54). +BuildRequires: perl(File::Copy) Ok. > FIX: Build-require `perl(base)' (builder/MyBuilder.pm:5). +BuildRequires: perl(base) Ok. > FIX: Build-require `perl(File::Path)' (builder/MyBuilder.pm:7). Not addressed. FIX: Please build-require it. > FIX: Build-require `perl(bytes)' (lib/WWW/Form/UrlEncoded/PP.pm:109). +BuildRequires: perl(bytes) Ok. The perl(File::Copy) is a good catch. $ rpmlint perl-WWW-Form-UrlEncoded.spec ../SRPMS/perl-WWW-Form-UrlEncoded-0.23-2.fc26.src.rpm ../RPMS/noarch/perl-WWW-Form-UrlEncoded-0.23-2.fc26.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. Package build in F26 (http://koji.fedoraproject.org/koji/taskinfo?taskID=16186162). Ok. Please add a build-time dependency on the `perl(File::Path))' before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx