[Bug 1387835] Review Request: python-binstruct - Library for read/ write access of binary data via structures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1387835



--- Comment #4 from Björn "besser82" Esser <fedora@xxxxxxxxxxx> ---
(In reply to Antonio Trande from comment #3)
> (In reply to Björn "besser82" Esser from comment #2)
> > (In reply to Antonio Trande from comment #1)
> > > Package Review
> > > ==============
> > > 
> > > Legend:
> > > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> > > [ ] = Manual review needed
> > > 
> > > === Issues ===
> > > 
> > > - Remove pre-built binstruct.egg-info/* files.
> > 
> > I don't think so…  That is a requirement from an outdated guideline…  See
> > the recent discussion on fedora-devel-ml [1] about that topic…
> > 
> > 
> > [1] 
> > https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/
> > message/FOG5APDRQVNXR5ZOZZSVDNZVN4WURKG4/
> 
> mmh...
> 
> This rule still does not look deprecated.
> 
> >Any package that uses setuptools or distutils will build egg-info.
> https://fedoraproject.org/wiki/Packaging:
> Python_Eggs#When_to_Provide_Egg_Metadata
> 
> >Do not distribute egg packages from upstream. In Fedora, all packages must be rebuilt from source.
> https://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Egg_Packages
> 
> http://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-
> built_binaries_or_libraries
> 
> This package uses setuptools to build egg files.

Yes, that is true… *BUT* .egg-info is metadata, not pre-built binaries…  There
is a huge difference between the the plain-text-files shipped in .egg-info and
a pre-built python-egg-package which is shipped as a .egg-file…

Nothing is the cited guidelines says one needs to remove generated metadata…

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]