[Bug 1384242] Review Request: python-astropy-helpers - Utilities for building and installing Astropy and affiliated package

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1384242



--- Comment #4 from Orion Poplawski <orion@xxxxxxxxxxxxx> ---
(In reply to Dominika Krejčí from comment #3)
> Is there any special reason why do you use `%{pythonX_pkgversion}` macro? I
> think you could use just 3 or 2, e.g. `python3-devel`.

For EPEL support - see
https://fedoraproject.org/wiki/PackagingDrafts:Python3EPEL

> Could you also specify Python 2 Requires?
> python-devel -> python2-devel
> python-setuptools -> python2-setuptools
> pytest -> python2-pytest
> numpy -> python2-numpy
> python-shipnx -> python2-sphinx

Same reason - EPEL uses the old names.

> Could you be please more specific in the `%files` section and do not use
> just `%{pythonX_sitelib}/*`, but for example this?
> %{python3_sitelib}/*astropy_helpers*.egg-info/
> %{python3_sitelib}/astropy_helpers/

How about:

%{python3_sitelib}/astropy_helpers*

Spec URL: https://www.cora.nwra.com/~orion/fedora/python-astropy-helpers.spec
SRPM URL:
https://www.cora.nwra.com/~orion/fedora/python-astropy-helpers-1.2-2.el7.src.rpm

* Fri Oct 21 2016 Orion Poplawski <orion@xxxxxxxxxxxxx> - 1.2-2
- Be more explicit in %%files

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]