https://bugzilla.redhat.com/show_bug.cgi?id=1103555 --- Comment #7 from Rich Mattes <richmattes@xxxxxxxxx> --- (In reply to Antonio Trande from comment #6) > > - LICENSE file is not packed > Please, include the changelog file, too. Good catch, I have included the changelog and license. > - You don't need to indicate the commit; this is the > release 0.5.0 > https://github.com/flexible-collision-library/fcl/releases/tag/0.5.0 Changed the Source0 to use the tag, as per the guidelines at https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Tags > - Why is release number not the same? > > $ ll rpms-unpacked/fcl-0.5.0-1.fc26.x86_64.rpm/usr/lib64 > -rwxr-xr-x. 1 sagitter sagitter 9443832 Oct 21 11:53 libfcl.so.0.5.0 > lrwxrwxrwx. 1 sagitter sagitter 15 Oct 21 12:02 libfcl.so.7 -> > libfcl.so.0.5.0 > It looks like upstream is bumping the ABI version (used in the soname) each time they make an ABI breaking change, and somehow it got out of sync with the minor version. I don't think it's a big deal that they're out of sync; at least they're setting a soversion and incrementing it when needed. New packages: Spec URL: http://rmattes.fedorapeople.org/RPMS/fcl/fcl.spec SRPM URL: http://rmattes.fedorapeople.org/RPMS/fcl/fcl-0.5.0-2.fc24.src.rpm rpmlint: $ rpmlint ./fcl.spec ../RPMS/x86_64/fcl-* fcl.x86_64: W: spelling-error %description -l en_US normals -> normal, normal's, formals fcl.x86_64: W: shared-lib-calls-exit /usr/lib64/libfcl.so.0.5.0 exit@GLIBC_2.2.5 fcl-devel.x86_64: W: only-non-binary-in-usr-lib fcl-devel.x86_64: W: no-documentation 3 packages and 1 specfiles checked; 0 errors, 4 warnings. scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16151741 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx