https://bugzilla.redhat.com/show_bug.cgi?id=1371158 --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. Source archive is original (SHA-256: 17f8a7a88758f5fe67c3e2f304f549b1543c3abfadf1d01053b280369238005f). Ok. The patch is good. Summary is Ok. FIX: While the library is LGPLv2, the examples files have different license (GPLv2+). You must add `License: LGPLv2 and GPLv2+' to the devel sub-package. FIX: Add a full-stop symbol at the end of the descriptions. FIX: Build-require `make' (ebtree.spec:41). FIX: Build-require `coreutils' (ebtree.spec:42). FIX: Build-require `gcc' (Makefile:13). FIX: Do not package LICENSE file twice (both %doc and %license). Use only %license. FIX: Export LDFLAGS for make. The linker command must use distribution flags from %{__global_ldflags} macro. TODO: Execute tests from %check section. Upstream has tests. Actually it would be great if the tests used the dynamic library so they checked the bits the RPM package will deliver to users. They uses the static library now. TODO: The library SONAME should be two-digit because this not an upstream versioning. It also does not make sense to start with "6". You could start with "0.1". <https://fedoraproject.org/wiki/Packaging:Guidelines#Downstream_.so_name_versioning>. $ rpmlint ebtree.spec ../SRPMS/ebtree-6.0.8-1.fc26.src.rpm ../RPMS/x86_64/ebtree-* ebtree.x86_64: E: library-without-ldconfig-postin /usr/lib64/libebtree.so.6.0 ebtree.x86_64: E: library-without-ldconfig-postun /usr/lib64/libebtree.so.6.0 ebtree-devel.x86_64: W: no-version-dependency-on ebtree/ebtree-libs/libebtree 6.0.8 ebtree-devel.x86_64: W: only-non-binary-in-usr-lib 4 packages and 1 specfiles checked; 2 errors, 2 warnings. FIX: You have to call ldconfig from post and postun scriptlets <https://fedoraproject.org/wiki/Packaging:Guidelines#SharedLibraries>. $ rpm -q -lv -p ../RPMS/x86_64/ebtree-6.0.8-1.fc26.x86_64.rpm lrwxrwxrwx 1 root root 16 Oct 21 11:24 /usr/lib64/libebtree.so.6 -> libebtree.so.6.0 -rwxr-xr-x 1 root root 19232 Oct 21 11:24 /usr/lib64/libebtree.so.6.0 drwxr-xr-x 2 root root 0 Oct 21 11:24 /usr/share/doc/ebtree -rw-r--r-- 1 root root 26436 Jun 11 2012 /usr/share/doc/ebtree/LICENSE -rw-r--r-- 1 root root 12297 Oct 21 11:24 /usr/share/doc/ebtree/README -rw-r--r-- 1 root root 6 Jun 11 2012 /usr/share/doc/ebtree/VERSION drwxr-xr-x 2 root root 0 Oct 21 11:24 /usr/share/licenses/ebtree -rw-r--r-- 1 root root 26436 Jun 11 2012 /usr/share/licenses/ebtree/LICENSE $ rpm -q -lv -p ../RPMS/x86_64/ebtree-devel-6.0.8-1.fc26.x86_64.rpm -rw-r--r-- 1 root root 2954 Jun 11 2012 /usr/include/compiler.h -rw-r--r-- 1 root root 15744 Jun 11 2012 /usr/include/eb32tree.h -rw-r--r-- 1 root root 18643 Jun 11 2012 /usr/include/eb64tree.h -rw-r--r-- 1 root root 10710 Jun 11 2012 /usr/include/ebimtree.h -rw-r--r-- 1 root root 10966 Jun 11 2012 /usr/include/ebistree.h -rw-r--r-- 1 root root 26000 Jun 11 2012 /usr/include/ebmbtree.h -rw-r--r-- 1 root root 5520 Jun 11 2012 /usr/include/ebpttree.h -rw-r--r-- 1 root root 10802 Jun 11 2012 /usr/include/ebsttree.h -rw-r--r-- 1 root root 31130 Jun 11 2012 /usr/include/ebtree.h lrwxrwxrwx 1 root root 14 Oct 21 11:24 /usr/lib64/libebtree.so -> libebtree.so.6 drwxr-xr-x 2 root root 0 Oct 21 11:24 /usr/share/doc/ebtree-devel -rw-r--r-- 1 root root 26436 Jun 11 2012 /usr/share/doc/ebtree-devel/LICENSE -rw-r--r-- 1 root root 12297 Oct 21 11:24 /usr/share/doc/ebtree-devel/README -rw-r--r-- 1 root root 6 Jun 11 2012 /usr/share/doc/ebtree-devel/VERSION drwxr-xr-x 2 root root 0 Jun 11 2012 /usr/share/doc/ebtree-devel/examples -rw-r--r-- 1 root root 4217 Jun 11 2012 /usr/share/doc/ebtree-devel/examples/reduce.c -rw-r--r-- 1 root root 2529 Jun 11 2012 /usr/share/doc/ebtree-devel/examples/squidgrep.c drwxr-xr-x 2 root root 0 Oct 21 11:24 /usr/share/licenses/ebtree-devel -rw-r--r-- 1 root root 26436 Jun 11 2012 /usr/share/licenses/ebtree-devel/LICENSE I don't like the compiler.h directly in /usr/include. The file name does not sound ebtree specific. I recommend to move the header files into a subdirectory /usr/include/ebtree. $ rpm -q --requires -p ../RPMS/x86_64/ebtree-6.0.8-1.fc26.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) $ rpm -q --requires -p ../RPMS/x86_64/ebtree-devel-6.0.8-1.fc26.x86_64.rpm | sort -f | uniq -c 1 ebtree 1 libebtree.so.6()(64bit) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Run-require exact ebtree package (NEVRA) from ebtree-devel package to keep them matching. $ rpm -q --provides -p ../RPMS/x86_64/ebtree-6.0.8-1.fc26.x86_64.rpm | sort -f | uniq -c 1 ebtree = 6.0.8-1.fc26 1 ebtree(x86-64) = 6.0.8-1.fc26 1 libebtree.so.6()(64bit) $ rpm -q --provides -p ../RPMS/x86_64/ebtree-devel-6.0.8-1.fc26.x86_64.rpm | sort -f | uniq -c 1 ebtree-devel = 6.0.8-1.fc26 1 ebtree-devel(x86-64) = 6.0.8-1.fc26 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/ebtree{,-devel}-6.0.8-1.fc26.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F26 (http://koji.fedoraproject.org/koji/taskinfo?taskID=16148863). Ok. Otherwise the package is in line with Fedora packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' items and provide a new spec file. Resolution: package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx