Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: MyBashBurn - burn data and songs. Alias: MyBashBurn https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217197 ------- Additional Comments From wilmer@xxxxxxxxxxxxxxxxx 2007-07-11 01:10 EST ------- Hi Jason, Thanks for testing it. (In reply to comment #37) > OK, this builds and installs fine in mock on x86_64 running rawhide. rpmlint says: > W: mybashburn spurious-executable-perm /usr/share/man/man1/mybashburn.1.gz > which is easily fixed by setting the permissions to 644 when you install it. Permissions now are correct, Fixed with: install -p m644 mybashburn.1.gz > Unfortunately when I attempted to test this, all I get is a message flashingg by > telling me "Terminal size must be fix, the size now is 80x24 Fai MyBashBurn > 1.0.2" and then the program exits. This is on an i386 machine running rawhide. This is oks, for that MyBashBurn working correctly when is running in any X term is necessary change the window "default size" manually, it not is a bug, does it draw the windows based on internal dialog program, also attempt that the user obtains best experience using the program, tries yourself for example to execute the program in a size of terminal major to 80x20, later resize terminal minor to 80x20 and you know of that I speak to you, whatever with or without resize it simply function right although it is not seen well. :D Finnally the user only must resize/extend a little the terminal and execute mybashburn, made simply, nevertheless when MyBashBurn is running in any not X terminal it working good. > You need to be consistent about your macro usage. If you want to use the > macroized forms like %{__sed} then you need to use %{__rm}, %{__install}, > %{__cp} and %{__ln}. I do not want to use that command macroized forms, s/%{_sed}/sed/ Fixed. > Don't start the summary with the name of the package. Fixed. > You install CREDITS and HOWTO twice. If they're required as internal help > files, they shouldn't also be installed as %doc. oks, you are right, removed CREDITS and HOWTO of %doc. Finnally thanks for your help on getting this worked out Jason. I've posted an updated mybashburn spec/SRPM on its review request, update files are on web project, please refresh: Spec: http://mybashburn.sourceforge.net/mybashburn.spec SRPM: http://mybashburn.sourceforge.net/mybashburn-1.0.2-2.src.rpm (In reply to comment #36) > I'll review this and emesene together > and, if those reviews go well, I'll sponsor you. A warning, though, emesene > might need some work. I'll working on a new emesene based on stable SVN version. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review