https://bugzilla.redhat.com/show_bug.cgi?id=1382922 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. Source0 archive is original (SHA-256: c87de2c895cf8a526bf5d3a231e6ca0e6d4cfdca72f8840b3fb039dbde478852). Ok. The WWW-Form-UrlEncoded-0.23-arch.patch patch is good. Ok. Summary verified from README.md. Ok. Description verified from README.md. Ok. License verified from lib/WWW/Form/UrlEncoded/PP.pm, lib/WWW/Form/UrlEncoded.pm, README.md, and LICENSE. Ok. No XS code, noarch BuildArch is Ok. FIX: Build-require `perl(File::Copy)' (Build.PL:54). FIX: Build-require `perl(base)' (builder/MyBuilder.pm:5). FIX: Build-require `perl(File::Path)' (builder/MyBuilder.pm:7). FIX: Build-require `perl(bytes)' (lib/WWW/Form/UrlEncoded/PP.pm:109). WWW::Form::UrlEncoded::XS is optional. Ok. All tests pass. Ok. $ rpmlint perl-WWW-Form-UrlEncoded.spec ../SRPMS/perl-WWW-Form-UrlEncoded-0.23-1.fc26.src.rpm ../RPMS/noarch/perl-WWW-Form-UrlEncoded-0.23-1.fc26.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-WWW-Form-UrlEncoded-0.23-1.fc26.noarch.rpm drwxr-xr-x 2 root root 0 Oct 21 10:23 /usr/share/doc/perl-WWW-Form-UrlEncoded -rw-r--r-- 1 root root 1239 Nov 19 2015 /usr/share/doc/perl-WWW-Form-UrlEncoded/Changes -rw-r--r-- 1 root root 4408 Nov 19 2015 /usr/share/doc/perl-WWW-Form-UrlEncoded/README.md drwxr-xr-x 2 root root 0 Oct 21 10:23 /usr/share/licenses/perl-WWW-Form-UrlEncoded -rw-r--r-- 1 root root 18418 Nov 19 2015 /usr/share/licenses/perl-WWW-Form-UrlEncoded/LICENSE -rw-r--r-- 1 root root 3647 Oct 21 10:23 /usr/share/man/man3/WWW::Form::UrlEncoded.3pm.gz -rw-r--r-- 1 root root 2125 Oct 21 10:23 /usr/share/man/man3/WWW::Form::UrlEncoded::PP.3pm.gz drwxr-xr-x 2 root root 0 Oct 21 10:23 /usr/share/perl5/vendor_perl/WWW drwxr-xr-x 2 root root 0 Oct 21 10:23 /usr/share/perl5/vendor_perl/WWW/Form drwxr-xr-x 2 root root 0 Oct 21 10:23 /usr/share/perl5/vendor_perl/WWW/Form/UrlEncoded -rw-r--r-- 1 root root 5091 Oct 21 10:23 /usr/share/perl5/vendor_perl/WWW/Form/UrlEncoded.pm -rw-r--r-- 1 root root 3942 Oct 21 10:23 /usr/share/perl5/vendor_perl/WWW/Form/UrlEncoded/PP.pm File permissions and layout is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-WWW-Form-UrlEncoded-0.23-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(:VERSION) >= 5.8.1 1 perl(base) 1 perl(bytes) 1 perl(Exporter) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-WWW-Form-UrlEncoded-0.23-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(WWW::Form::UrlEncoded) = 0.23 1 perl(WWW::Form::UrlEncoded::PP) 1 perl-WWW-Form-UrlEncoded = 0.23-1.fc26 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-WWW-Form-UrlEncoded-0.23-1.fc26.noarch.rpm Binary dependencies resolvable. Ok. Package build in F26 (http://koji.fedoraproject.org/koji/taskinfo?taskID=16148067). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items and provides an updated spec files. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx