https://bugzilla.redhat.com/show_bug.cgi?id=1376511 --- Comment #4 from Michael Schwendt <bugs.michael@xxxxxxx> --- Drive-by comments. Not easy to review, not a full review. Needs some more work: > Name: nexus > Summary: NeXus scientific data file format This %summary could be improved, because so far it is for insiders only and doesn't give a hint what is included in this package. Judging on the %files section contents, this is a library-only package. No program, not tools, and the %summary could mention that. Such as: Summary: Library for handling NeXus scientific data files It's written in C++ and offers shared library APIs for C, C++ and Fortran it seems. Offering all of them in a single package could be drawback because of what is pulled in via implicit dependencies. Also visit https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries and: https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries > License: LGPL https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text Further, the -tools subpackage contains a GPLv2 license text as one of the files in a %doc folder. This needs to be reflected in the "License" tag of that package, and the %license macro ought to be used. There is another "LICENSE" file included. Consider pointing the fedora-review tool at this bugzilla ticket, since it automates many checks related to licensing. > Requires: libgfortran > Requires: hdf5 > Requires: hdf > Requires: mxml https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > %package devel > Summary: Development files for %{name} > Requires: %{name} = %{version}-%{release} https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > %package tools > Requires: %{name} = %{version}-%{release} > Requires: libxml2 > Requires: readline https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > %install > rm -rf $RPM_BUILD_ROOT > %make_install https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections > %files > %doc %{_datadir}/doc/NeXus/README.doc > %{_libdir}/libNeXus* > %{_libdir}/nexus/ https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership Particularly https://fedoraproject.org/wiki/Packaging:UnownedDirectories since directory /usr/share/doc/NeXus/ would not be included. Similar problem for the -tools subpackage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx