https://bugzilla.redhat.com/show_bug.cgi?id=1385728 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok Source archive is original (SHA-256: ef6813ea8af51724304449998db21ea2a93b25825549eb79d3f1e9171feace33). Ok. Summary verified from lib/Specio/Library/Path/Tiny.pm. Ok. Description verified from lib/Specio/Library/Path/Tiny.pm. Ok. License verified from README.md, lib/Specio/Library/Path/Tiny.pm, LICENSE. Ok. No XS code, noarch BuildArch is Ok. CPAN::Meta and CPAN::Meta::Prereqs are not helpful in tests. Ok. All tests pass. Ok. $ rpmlint perl-Specio-Library-Path-Tiny.spec ../SRPMS/perl-Specio-Library-Path-Tiny-0.04-1.fc26.src.rpm ../RPMS/noarch/perl-Specio-Library-Path-Tiny-0.04-1.fc26.noarch.rpm perl-Specio-Library-Path-Tiny.src: W: spelling-error Summary(en_US) coercions -> coercion, coercion's, coercion s perl-Specio-Library-Path-Tiny.src: W: spelling-error %description -l en_US coercions -> coercion, coercion's, coercion s perl-Specio-Library-Path-Tiny.src: W: spelling-error %description -l en_US ValidationCompiler -> Validation Compiler, Validation-compiler, Compartmentalization perl-Specio-Library-Path-Tiny.noarch: W: spelling-error Summary(en_US) coercions -> coercion, coercion's, coercion s perl-Specio-Library-Path-Tiny.noarch: W: spelling-error %description -l en_US coercions -> coercion, coercion's, coercion s perl-Specio-Library-Path-Tiny.noarch: W: spelling-error %description -l en_US ValidationCompiler -> Validation Compiler, Validation-compiler, Compartmentalization 2 packages and 1 specfiles checked; 0 errors, 6 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Specio-Library-Path-Tiny-0.04-1.fc26.noarch.rpm drwxr-xr-x 2 root root 0 Oct 18 09:40 /usr/share/doc/perl-Specio-Library-Path-Tiny -rw-r--r-- 1 root root 4275 Oct 15 23:33 /usr/share/doc/perl-Specio-Library-Path-Tiny/CONTRIBUTING.md -rw-r--r-- 1 root root 490 Oct 15 23:33 /usr/share/doc/perl-Specio-Library-Path-Tiny/Changes -rw-r--r-- 1 root root 4207 Oct 15 23:33 /usr/share/doc/perl-Specio-Library-Path-Tiny/README.md drwxr-xr-x 2 root root 0 Oct 18 09:40 /usr/share/licenses/perl-Specio-Library-Path-Tiny -rw-r--r-- 1 root root 11499 Oct 15 23:33 /usr/share/licenses/perl-Specio-Library-Path-Tiny/LICENSE -rw-r--r-- 1 root root 2390 Oct 18 09:40 /usr/share/man/man3/Specio::Library::Path::Tiny.3pm.gz drwxr-xr-x 2 root root 0 Oct 18 09:40 /usr/share/perl5/vendor_perl/Specio drwxr-xr-x 2 root root 0 Oct 18 09:40 /usr/share/perl5/vendor_perl/Specio/Library drwxr-xr-x 2 root root 0 Oct 18 09:40 /usr/share/perl5/vendor_perl/Specio/Library/Path -rw-r--r-- 1 root root 10349 Oct 15 23:33 /usr/share/perl5/vendor_perl/Specio/Library/Path/Tiny.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Specio-Library-Path-Tiny-0.04-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(overload) 1 perl(parent) 1 perl(Path::Tiny) >= 0.087 1 perl(Scalar::Util) 1 perl(Specio) >= 0.29 1 perl(Specio::Declare) 1 perl(Specio::Exporter) 1 perl(Specio::Library::Builtins) 1 perl(Specio::PartialDump) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Specio-Library-Path-Tiny-0.04-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(Specio::Library::Path::Tiny) = 0.04 1 perl-Specio-Library-Path-Tiny = 0.04-1.fc26 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Specio-Library-Path-Tiny-0.04-1.fc26.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F26 (http://koji.fedoraproject.org/koji/taskinfo?taskID=16111174). Ok. Package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx