https://bugzilla.redhat.com/show_bug.cgi?id=1381132 --- Comment #2 from MartinKG <mgansser@xxxxxxxx> --- Hi Dominika, (In reply to Dominika Krejčí from comment #1) > Hi Martin, I have some comments. > > * The last version of barrust/Wikipedia is 1.4.5 and the commit used in > `Source0` also corresponds with 1.4.5. Why is there 1.4.4 in the `Version` > tag? ok update to new version > > * The `Source0` url creates directory with ugly name, it should be named > `%{srcname}-%{version}.tar.gz`. > done > * It is useless to create a %{sum} macro. Just write the content to > `Summary` and in the rest of the file you can use %{summary} marco. ;) > done > * Rather then `python-requests` be more specific and use `python2-requests`, > wherever it is possible. done New rpm files: Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-wikipedia.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-wikipedia-1.4.5-1.fc24.src.rpm %changelog * Fri Oct 14 2016 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - 1.4.5-1 - Update to 1.4.5-1 - Cleanup spec file - Use Requires python2-requests - Write the content to Summary and in the rest use %%{summary} marco -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx