https://bugzilla.redhat.com/show_bug.cgi?id=1373019 Dominika Krejčí <dkrejci@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dkrejci@xxxxxxxxxx --- Comment #1 from Dominika Krejčí <dkrejci@xxxxxxxxxx> --- Hi Juan, I have some recommendations for you. * Is there any reason for defining `commit` and `shortcommit` macros? I would be more benefitial to define `srcname` macro for "fuse". * The `Source0` url should create directory which is named `%{srcname}-%{version}.tar.gz`, not just `%{version}.tar.gz`. (You can just add `#/%{srcname}-%{version}.tar.gz` to your current url.) * You do not have to rewrite summary manually. Just reuse the first Summary tag with the %{summary} macro. * "If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it." -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx