https://bugzilla.redhat.com/show_bug.cgi?id=1383781 gil cattaneo <puntogil@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |puntogil@xxxxxxxxx --- Comment #1 from gil cattaneo <puntogil@xxxxxxxxx> --- Issues: license is MIT. See https://sourceforge.net/p/sunflow/code/HEAD/tree/trunk/LICENSE Use %license macro instead of %doc LICENSE https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_example sunflow.jdk.level must be 6 or major, instead of 5 (necessary for JVM >= 1.8) All source files are without license headers. Please, ask to upstream to confirm the licensing of code and/or content/s, and add license headers https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification Please, add better description near the patches -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx