[Bug 1324784] Review Request: pseudo - Advanced tool for simulating superuser privileges

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1324784



--- Comment #14 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> ---
(In reply to Igor Gnatenko from comment #13)
> As I can see, not all bits were applied from patch which I attached...
> 
> > BuildRequires:   attr
> not removed, it's useless BR

configure checks for getfattr availability at build time and prints a warning
if it's not present. Failure to run getfattr doesn't disable any features
though, so I'll drop this BR and patch out the warning instead.

> > sed -i -e "/s,@ARCH_FLAGS@/s|,|!|g" configure
> I don't see this, but build was failing because we have commas in CFLAGS.

I know. I fixed it another way. See the new patch.

> > link=$(readlink -e "%{_bindir}/fakeroot")
> IMO we have fakeroot with alternatives support for long time, so this part
> can be skipped.

The fakeroot in RHEL5 doesn't support alternatives. Neither does the one in
RHEL6.

> Now I'm not around laptop, once I will have it - I will check that it
> builds, some trivial stuff and approve.

I checked that it builds across all primary arches via koji scratch build.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]