https://bugzilla.redhat.com/show_bug.cgi?id=1360255 --- Comment #5 from Raphael Groner <projects.rg@xxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: qt5-qtcharts-examples : /usr/lib64/qt5/examples/charts/barmodelmapper/customtablemodel.h qt5 -qtcharts-examples : /usr/lib64/qt5/examples/charts/barmodelmapper/tablewidget.h qt5-qtcharts- examples : /usr/lib64/qt5/examples/charts/boxplotchart/boxdatareader.h qt5-qtcharts-examples : /usr/lib64/qt5/examples/charts/callout/callout.h qt5-qtcharts-examples : /usr/lib64/qt5/examples/charts/callout/view.h qt5 -qtcharts-examples : /usr/lib64/qt5/examples/charts/chartinteractions/chart.h qt5-qtcharts- examples : /usr/lib64/qt5/examples/charts/chartinteractions/chartview.h qt5-qtcharts-examples : /usr/lib64/qt5/examples/charts/chartthemes/themewidget.h qt5-qtcharts- examples : /usr/lib64/qt5/examples/charts/donutbreakdown/donutbreakdownchart.h qt5 -qtcharts-examples : /usr/lib64/qt5/examples/charts/donutbreakdown/mainslice.h qt5-qtcharts- examples : /usr/lib64/qt5/examples/charts/dynamicspline/chart.h qt5 -qtcharts-examples : /usr/lib64/qt5/examples/charts/legend/mainwidget.h qt5-qtcharts-examples : /usr/lib64/qt5/examples/charts/legendmarkers/mainwidget.h qt5-qtcharts- examples : /usr/lib64/qt5/examples/charts/modeldata/customtablemodel.h qt5-qtcharts-examples : /usr/lib64/qt5/examples/charts/modeldata/tablewidget.h qt5-qtcharts- examples : /usr/lib64/qt5/examples/charts/nesteddonuts/widget.h qt5 -qtcharts-examples : /usr/lib64/qt5/examples/charts/openglseries/datasource.h qt5-qtcharts- examples : /usr/lib64/qt5/examples/charts/piechartcustomization/brushtool.h qt5 -qtcharts-examples : /usr/lib64/qt5/examples/charts/piechartcustomization/customslice.h qt5 -qtcharts-examples : /usr/lib64/qt5/examples/charts/piechartcustomization/mainwidget.h qt5 -qtcharts-examples : /usr/lib64/qt5/examples/charts/piechartcustomization/pentool.h qt5 -qtcharts-examples : /usr/lib64/qt5/examples/charts/piechartdrilldown/drilldownchart.h qt5 -qtcharts-examples : /usr/lib64/qt5/examples/charts/piechartdrilldown/drilldownslice.h qt5 -qtcharts-examples : /usr/lib64/qt5/examples/charts/polarchart/chartview.h qt5-qtcharts- examples : /usr/lib64/qt5/examples/charts/qmloscilloscope/datasource.h qt5-qtcharts-examples : /usr/lib64/qt5/examples/charts/scatterchart/chartview.h qt5-qtcharts- examples : /usr/lib64/qt5/examples/charts/scatterinteractions/chartview.h qt5-qtcharts-examples : /usr/lib64/qt5/examples/charts/stackedbarchartdrilldown/drilldownchart.h qt5-qtcharts-examples : /usr/lib64/qt5/examples/charts/stackedbarchartdrilldown/drilldownseries.h qt5-qtcharts-examples : /usr/lib64/qt5/examples/charts/zoomlinechart/chart.h qt5-qtcharts- examples : /usr/lib64/qt5/examples/charts/zoomlinechart/chartview.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages => Maybe move the sources of examples into a noarch subpackage or in devel. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. => LGTM, common practice for qml extensions. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1276 files have unknown license. Detailed output of licensecheck in /home/builder/fedora- review/1360255-qt5-qtcharts/licensecheck.txt => OK. Special Qt license header is not known to licensecheck. [!]: License file installed when any subpackage combination is installed. => You say License: GFDL for doc subpackage but there's no license file. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc/qt5 => %{_qt5_docdir} is owned by qt5-qtbase. => Add %dir %{_qt5_docdir} into doc subpackage (workaround due to noarch). [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/qt5/examples(qt5 -qtdeclarative-examples, qt5-qtvirtualkeyboard-examples, qt5 -qtsensors-examples, qt5-qt3d-examples, qt5-qtsvg-examples, qt5 -qtmultimedia-examples, qt5-qtbase-examples, qt5-qttools-examples, qt5 -qtwebchannel-examples, qt5-qtserialbus-examples, qt5-qtxmlpatterns- examples, qt5-qtquickcontrols-examples, qt5-qtserialport-examples, qt5 -qtwebsockets-examples, qt5-qtscript-examples, qt5-qtwebengine- examples, qt5-qtenginio-examples, qt5-qtconnectivity-examples, qt5 -qtlocation-examples) => LGTM, common practice for qt5 examples. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. => See below for rpmlint W: incoherent-version-in-changelog. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [!]: Development files must be in a -devel package => See above for examples. [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [-]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [!]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). => See below. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx