https://bugzilla.redhat.com/show_bug.cgi?id=1375999 --- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Aurelien Bompard from comment #2) > (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > > In %files, please enumerate the items under %{pythonX_sitelib}/ explicitly. > > Something like > > %{python2_sitelib}/libname > > %{python2_sitelib}/libname-%{version}.egg-info > > Hmm, this does not look like what the template python file suggests: > https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file > Are you sure? What would be the reason to explicitely list them? Indeed. I'm a bit surprised that the template does not suggest that. I'll file a ticket for FPC later. The justification for the explicit patterns: 1. when reading the spec file (during review or at any later time), you don't need to *guess* what module name is provided 2. it catches some common errors: - for example, some packages by mistake install tests as a top level-module - some packages install multiple top-level modules unexpectedly - sometimes the python2 and python3 paths gets mixed up 3. those patterns don't require updating if done properly, but you'll get notified if something changes in the package. For an example, see https://bugzilla.redhat.com/show_bug.cgi?id=1375962. It uses: %{python2_sitelib}/%{srcname}-%{version}*-py%{python2_version}.egg-info/ %{python2_sitelib}/%{srcname}/ %{python3_sitelib}/%{srcname}-%{version}*-py%{python3_version}.egg-info/ %{python3_sitelib}/%{srcname}/ Same as in the other package, you can replace the second and subsequent Summary texts with %{summary}, no need to repeat. /usr/lib/python3.5/site-packages/flufl/bounce/NEWS.rst → this should be in %doc /usr/lib/python3.5/site-packages/flufl/bounce/README.rst → this one is repeated from %doc /usr/lib/python3.5/site-packages/flufl/bounce/docs/using.rst → another candidate for %doc conf.py which is for sphinx gets installed as flufl.bounce.conf, you probably want to delete that to avoid confusion and spurious dependencies. In general, you should fix the installation to remove documentation and the related sphinx config from site-packages dirs. The package is essentially OK, but please submit another version, I'll do one more check of paths and provides/requires. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx