https://bugzilla.redhat.com/show_bug.cgi?id=1382875 Jens Lody <fedora@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxxxx Flags| |fedora-review? --- Comment #2 from Jens Lody <fedora@xxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://admin.fedoraproject.org/pkgdb/package/psad See: https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later) (with incorrect FSF address)", "BSD (3 clause)", "Unknown or generated". 63 files have unknown license. Detailed output of licensecheck in /home/jens/reviews/rawhide/1382875-psad/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /etc/logrotate.d(samba- common, logrotate, ppp, sssd-common) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [?]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in psad- debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: psad-2.4.3-1.fc26.x86_64.rpm psad-debuginfo-2.4.3-1.fc26.x86_64.rpm psad-2.4.3-1.fc26.src.rpm psad.x86_64: W: spelling-error %description -l en_US firewalling -> fire walling, fire-walling, firewall psad.x86_64: W: spelling-error %description -l en_US tcp -> pct, tsp, tip psad.x86_64: W: spelling-error %description -l en_US nmap -> nap, map, neap psad.x86_64: W: spelling-error %description -l en_US syslog -> slog psad.x86_64: W: spelling-error %description -l en_US ip -> pi, up, op psad.x86_64: W: spelling-error %description -l en_US rulesets -> rule sets, rule-sets, russets psad.x86_64: W: spelling-error %description -l en_US udp -> up, pud, ump psad.x86_64: W: spelling-error %description -l en_US icmp -> imp, RCMP psad.x86_64: W: spelling-error %description -l en_US mstream -> stream, m stream, seamstress psad.x86_64: W: spelling-error %description -l en_US xmas -> Xmas, mas, x mas psad.x86_64: W: spelling-error %description -l en_US fwsnort -> snort psad.x86_64: E: non-standard-dir-perm /var/log/psad 700 psad.x86_64: E: dir-or-file-in-var-run /var/run/psad psad.x86_64: E: non-standard-dir-perm /var/run/psad 700 psad.x86_64: E: dir-or-file-in-var-run /var/run/psad/psad.cmd psad.x86_64: E: non-readable /var/run/psad/psad.cmd 700 psad.x86_64: E: non-standard-executable-perm /var/run/psad/psad.cmd 700 psad.x86_64: E: non-readable /var/lib/psad/psadfifo 700 psad.x86_64: E: non-standard-executable-perm /var/lib/psad/psadfifo 700 psad.x86_64: E: incorrect-fsf-address /usr/share/licenses/psad/LICENSE psad.x86_64: E: non-standard-dir-perm /var/lib/psad 700 psad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/psad-2.4.3/psad.h psad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/psad-2.4.3/kmsgsd.c psad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/psad-2.4.3/psad_funcs.c psad.src: W: spelling-error %description -l en_US iptables -> stables, tables psad.src: W: spelling-error %description -l en_US firewalling -> fire walling, fire-walling, firewall psad.src: W: spelling-error %description -l en_US tcp -> pct, tsp, tip psad.src: W: spelling-error %description -l en_US nmap -> nap, map, neap psad.src: W: spelling-error %description -l en_US syslog -> slog psad.src: W: spelling-error %description -l en_US ip -> pi, up, op psad.src: W: spelling-error %description -l en_US rulesets -> rule sets, rule-sets, russets psad.src: W: spelling-error %description -l en_US udp -> up, pud, ump psad.src: W: spelling-error %description -l en_US icmp -> imp, RCMP psad.src: W: spelling-error %description -l en_US mstream -> stream, m stream, seamstress psad.src: W: spelling-error %description -l en_US xmas -> Xmas, mas, x mas psad.src: W: spelling-error %description -l en_US fwsnort -> snort 3 packages and 0 specfiles checked; 13 errors, 23 warnings. Rpmlint (debuginfo) ------------------- Checking: psad-debuginfo-2.4.3-1.fc26.x86_64.rpm psad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/psad-2.4.3/psad_funcs.c psad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/psad-2.4.3/psad.h psad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/psad-2.4.3/kmsgsd.c 1 packages and 0 specfiles checked; 3 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- psad.x86_64: W: spelling-error %description -l en_US firewalling -> fire walling, fire-walling, firewall psad.x86_64: W: spelling-error %description -l en_US tcp -> pct, tsp, tip psad.x86_64: W: spelling-error %description -l en_US nmap -> nap, map, neap psad.x86_64: W: spelling-error %description -l en_US syslog -> slog psad.x86_64: W: spelling-error %description -l en_US ip -> pi, up, op psad.x86_64: W: spelling-error %description -l en_US rulesets -> rule sets, rule-sets, russets psad.x86_64: W: spelling-error %description -l en_US udp -> up, pud, ump psad.x86_64: W: spelling-error %description -l en_US icmp -> imp, RCMP psad.x86_64: W: spelling-error %description -l en_US mstream -> stream, m stream, seamstress psad.x86_64: W: spelling-error %description -l en_US xmas -> Xmas, mas, x mas psad.x86_64: W: spelling-error %description -l en_US fwsnort -> snort psad.x86_64: E: dir-or-file-in-var-run /var/run/psad psad.x86_64: E: non-standard-dir-perm /var/run/psad 700 psad.x86_64: E: non-standard-dir-perm /var/lib/psad 700 psad.x86_64: E: non-readable /var/lib/psad/psadfifo 700 psad.x86_64: E: non-standard-executable-perm /var/lib/psad/psadfifo 700 psad.x86_64: E: dir-or-file-in-var-run /var/run/psad/psad.cmd psad.x86_64: E: non-readable /var/run/psad/psad.cmd 700 psad.x86_64: E: non-standard-executable-perm /var/run/psad/psad.cmd 700 psad.x86_64: E: non-standard-dir-perm /var/log/psad 700 psad.x86_64: E: incorrect-fsf-address /usr/share/licenses/psad/LICENSE psad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/psad-2.4.3/psad.h psad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/psad-2.4.3/psad_funcs.c psad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/psad-2.4.3/kmsgsd.c 2 packages and 0 specfiles checked; 13 errors, 11 warnings. Requires -------- psad (rpmlib, GLIBC filtered): /bin/sh /usr/bin/perl config(psad) iptables libc.so.6()(64bit) perl(Bit::Vector) perl(Carp::Clan) perl(Data::Dumper) perl(Date::Calc) perl(File::Copy) perl(File::Path) perl(Getopt::Long) perl(IO::Handle) perl(IO::Select) perl(IO::Socket) perl(IPTables::ChainMgr) perl(IPTables::Parse) perl(NetAddr::IP) perl(POSIX) perl(Socket) perl(Storable) perl(Unix::Syslog) perl(strict) rtld(GNU_HASH) psad-debuginfo (rpmlib, GLIBC filtered): Provides -------- psad: config(psad) psad psad(x86-64) psad-debuginfo: psad-debuginfo psad-debuginfo(x86-64) Source checksums ---------------- https://www.cipherdyne.org/psad/download/psad-2.4.3.tar.bz2 : CHECKSUM(SHA256) this package : e482de4602ab72dba868dcdd1078ad3645d49ab02a9eb116dd117c1a5a20f8c5 CHECKSUM(SHA256) upstream package : e482de4602ab72dba868dcdd1078ad3645d49ab02a9eb116dd117c1a5a20f8c5 https://www.cipherdyne.org/psad/download/psad-2.4.3.tar.bz2.asc : CHECKSUM(SHA256) this package : 6a11a7fdbf054bff8dbd7458bfb722a7c00218d9661e2e63a6832ba4cef85534 CHECKSUM(SHA256) upstream package : 6a11a7fdbf054bff8dbd7458bfb722a7c00218d9661e2e63a6832ba4cef85534 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1382875 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx