Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kdebluetooth: The KDE Bluetooth Framework (take/2) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235203 ------- Additional Comments From rdieter@xxxxxxxxxxxx 2007-07-10 09:25 EST ------- This has lingered long enough... :) 1. MUST: fix scriptlets, add missing 'touch', before gtk-update-icon-cache: touch --no-create %{_datadir}/icons/hicolor ||: 2. MUST: omit stray .la files, add near end of %install: rm -f $RPM_BUILD_ROOT%{_libdir}/lib*.la and fix %files list accordingly. (unless you've discovered these are actually required) 3. SHOULD remove --add-only-show-in="KDE" This isn't (shouldn't be!?) desktop-specific, and could be of value to users of other desktops. I don't feel strongly about it, tho. 4. SHOULD omit BuildRequires: libutempter-devel not sure why that's included (I suspect due to the kde packaging bug that's long-since been fixed). 5. SHOULD use %{?dist} in Release, something like: Release: 0.25.beta3%{?dist} Address these, and I'll approve this. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review