https://bugzilla.redhat.com/show_bug.cgi?id=1382755 --- Comment #2 from Christoph Junghans <junghans@xxxxxxxxx> --- (In reply to Igor Gnatenko from comment #1) > > License: Apache-2.0 > ASL 2.0 Fixed. > > > Group: Productivity/Networking/Other > > Group: Development/Libraries/C and C++ > no need for that Dropped. > > > %{_includedir}/* > this is dangerous Made more specific. > > * Missing BuildRequires: gcc > * Missing BuildRequires: gcc-c++ Hmm, fedora review says: Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 > * Can you reorder %files sections (I was a bit confused ;)) Sure, done. Spec URL: http://junghans.github.io/fedora-review/legion/legion.spec SRPM URL: http://junghans.github.io/fedora-review/legion/legion-16.10.0-1.fc26.src.rpm Review.txt: http://junghans.github.io/fedora-review/legion/review.txt Build log: https://travis-ci.org/junghans/fedora-review/builds/165966382 Raw Build log: https://s3.amazonaws.com/archive.travis-ci.org/jobs/165966383/log.txt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx