[Bug 1381935] Review Request: python-distro - Linux Distribution - a Linux OS platform information API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1381935



--- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> ---
* Naming is correct.
* License is correct.
* Python 2 and Python 3 subpackages are being correctly generated for Fedora.

However, I see a few issues:
* Starting with Fedora 23, the default implementation of commands should be
Python 3 instead of Python 2. Please switch /usr/bin/distro to Python 3.
* You are hard-requiring /bin/lsb_release, which upstream says is not
necessary. Please downgrade it to Recommends, as the lsb package has a large
web of dependencies that people may not necessarily want.
* If you intend to package this for EPEL, you'll need to do a little bit more
work to support Python 3 in EPEL 6/7. For reference, here's a couple of
examples[1][2].


[1]: https://apps.fedoraproject.org/packages/python-nose2/sources/spec/
[2]: https://apps.fedoraproject.org/packages/python-pika/sources/spec/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]