[Bug 1375999] Review Request: python-flufl.bounce - Email bounce detectors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1375999



--- Comment #2 from Aurelien Bompard <aurelien@xxxxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> Same comments as for the other review, see
> https://bugzilla.redhat.com/show_bug.cgi?id=1376001#c1.
> 
> Also, don't repeat the %description, it makes the spec file much harder to
> read than necessary

I renamed the package, and used a macro for summary and description. Nice, I
did not know one could have multiline text with backslashes :-)

> In %files, please enumerate the items under %{pythonX_sitelib}/ explicitly.
> Something like
> %{python2_sitelib}/libname
> %{python2_sitelib}/libname-%{version}.egg-info

Hmm, this does not look like what the template python file suggests:
https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
Are you sure? What would be the reason to explicitely list them?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]