[Bug 1376783] Review Request: python-can: The can package provides controller area network support for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1376783

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zbyszek@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx



--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
The packaging tempalte from
https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file should
be used. It's much better to use %pyX_build, etc.

The description should be wrapped to <= 80 columns, this is even visible in the
way that bugzilla formats the description above.

Is python fully supported? Than the executables should use python3 not python2.


You can replace the second and subsequent Summary texts with %{summary}, no
need to repeat.


Also, don't repeat the %description, it makes the spec file much harder to read
than necessary:

%global _description \
XXX \
YYY

%description -n package-name %{_description}

etc.

In %files, please enumerate the items under %{pythonX_sitelib}/ explicitly.
Something like
%{python2_sitelib}/libname
%{python2_sitelib}/libname-%{version}.egg-info

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]