[Bug 1327981] Review Request: python-ipykernel - IPython Kernel for Jupyter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1327981



--- Comment #9 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
rpmlint:
python2-ipykernel.noarch: W: spelling-error Summary(en_US) IPython -> I Python,
Python, Diphthong
python3-ipykernel.noarch: W: spelling-error Summary(en_US) IPython -> I Python,
Python, Diphthong
python-ipykernel.src: W: spelling-error Summary(en_US) IPython -> I Python,
Python, Diphthong
python-ipykernel-doc.noarch: W: spelling-error Summary(en_US) IPython -> I
Python, Python, Diphthong
Yeah, way to go rpmlint!

python-ipykernel-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/python-ipykernel-doc/html/objects.inv
python-ipykernel-doc.noarch: W: file-not-utf8
/usr/share/doc/python-ipykernel-doc/html/objects.inv
Those are not text files, so OK.

4 packages and 0 specfiles checked; 0 errors, 6 warnings.

Hm, this requires python-ipython 4, while we have 3.2.1 in rawhide... Do we
have some tracking bug for the update of python-ipython?

I think you need R:python[23]-zmq.

Where does ipython_genutils module come from?

import gi
gi.require_version ('Gdk', '3.0')
gi.require_version ('Gtk', '3.0')
from gi.repository import GObject, Gtk
→ don't you need dependencies on python[23]-gobject-base, gtk3,
gobject-introspection for those?

import matplotlib
from matplotlib.backends.backend_agg import new_figure_manager, FigureCanvasAgg
# analysis: ignore
from matplotlib._pylab_helpers import Gcf
→ more requires?

Also python[23]-pillow?

I think you can drop README.md from the doc directory, it's only about building
the package and running tests from the source tree. Not useful for the binary
package.

For the %description:
This package provide the IPython kernel for the Jupyter notebook. The notebook
provides a front-end to enter and edit commands, and display results, while
this package wraps the backend, i.e. the actual IPython instance that will
execute Python commands supplied by the frontend.

+ provides look OK
+ %python_provide is used
+ all modern python macros are used
+ doc subpackage is present
+ builds OK
- a few Requires seem to be missing

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]