https://bugzilla.redhat.com/show_bug.cgi?id=1381307 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tcallawa@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |tcallawa@xxxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> --- = Review = Good: - rpmlint checks return: nothing - package meets naming guidelines - package meets packaging guidelines - license (GPL+ or Artistic) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (989d341b6c625d240c54457e40a76d646d7243e2a5c0d0d19fe3ccb3a18742bf) - package compiles on f24 (noarch) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx