Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mysql-proxy - A proxy for the MySQL Client/Server protocol https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246403 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Component|pachi |Package Review Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-07-09 20:27 EST ------- It seems that 0.5.1 is now out. I managed to download 0.5.0 from a mirror and will review it here; I don't see significant changes in 0.5.1 so I don't think I need to wait for you to update before I review. I managed to get things from http://mysql.he.net/Downloads/MySQL-Proxy/; I think it's better to list some URL, even a mirror, rather than nothing, but that's really up to you. I suppose a package like this could use an init file, but I don't think it's mandatory. Review: * source files match upstream: e1e1951d8bddfc0813aad1a3a93e63229dd9baa82833569cb44237cb769a2669 mysql-proxy-0.5.0.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. X latest version is 0.5.1. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: mysql-proxy = 0.5.0-1.fc8 = libevent-1.3b.so.1()(64bit) libglib-2.0.so.0()(64bit) liblua-5.1.so()(64bit) * %check is not present; no test suite upstream. Some basic testing shows that it seems to work. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review