https://bugzilla.redhat.com/show_bug.cgi?id=1378028 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source addresses are usable. Ok. Source archive is original (SHA-256: fecc71952ab13b88f65e6e3bb8815dae915c78455a098cc31af9842253c4dc81). Ok. Summary is Ok. Description verified from README.md. Ok. License verified from lib/MCE/Shared.pm, README.md, Copying, LICENSE. Ok. No XS code, noarch BuildArch is Ok. TODO: The dependency on `perl >= 4:5.10.1' is better written as `perl(:VERSION) >= 5.10.1'. You don't have to deal with the epoch number. (Although it's probably unavailable on EPEL.) All tests pass. Ok. $ rpmlint perl-MCE-Shared.spec ../SRPMS/perl-MCE-Shared-1.805-1.fc26.src.rpm ../RPMS/noarch/perl-MCE-Shared-1.805-1.fc26.noarch.rpm perl-MCE-Shared.src: W: spelling-error %description -l en_US parallelization -> palatalization, rationalization, pluralization perl-MCE-Shared.noarch: W: spelling-error %description -l en_US parallelization -> palatalization, rationalization, pluralization 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-MCE-Shared-1.805-1.fc26.noarch.rpm drwxr-xr-x 2 root root 0 Oct 3 16:55 /usr/share/doc/perl-MCE-Shared -rw-r--r-- 1 root root 4350 Sep 23 08:04 /usr/share/doc/perl-MCE-Shared/Changes -rw-r--r-- 1 root root 3900 Sep 23 07:58 /usr/share/doc/perl-MCE-Shared/README.md drwxr-xr-x 2 root root 0 Oct 3 16:55 /usr/share/licenses/perl-MCE-Shared -rw-r--r-- 1 root root 12633 Aug 22 2015 /usr/share/licenses/perl-MCE-Shared/Copying -rw-r--r-- 1 root root 6319 Aug 22 2015 /usr/share/licenses/perl-MCE-Shared/LICENSE -rw-r--r-- 1 root root 5657 Oct 3 16:54 /usr/share/man/man3/MCE::Hobo.3pm.gz -rw-r--r-- 1 root root 8016 Oct 3 16:54 /usr/share/man/man3/MCE::Shared.3pm.gz -rw-r--r-- 1 root root 5554 Oct 3 16:54 /usr/share/man/man3/MCE::Shared::Array.3pm.gz -rw-r--r-- 1 root root 1255 Oct 3 16:54 /usr/share/man/man3/MCE::Shared::Base.3pm.gz -rw-r--r-- 1 root root 3607 Oct 3 16:54 /usr/share/man/man3/MCE::Shared::Condvar.3pm.gz -rw-r--r-- 1 root root 3634 Oct 3 16:54 /usr/share/man/man3/MCE::Shared::Handle.3pm.gz -rw-r--r-- 1 root root 4574 Oct 3 16:54 /usr/share/man/man3/MCE::Shared::Hash.3pm.gz -rw-r--r-- 1 root root 7275 Oct 3 16:54 /usr/share/man/man3/MCE::Shared::Minidb.3pm.gz -rw-r--r-- 1 root root 7037 Oct 3 16:54 /usr/share/man/man3/MCE::Shared::Ordhash.3pm.gz -rw-r--r-- 1 root root 4372 Oct 3 16:54 /usr/share/man/man3/MCE::Shared::Queue.3pm.gz -rw-r--r-- 1 root root 2329 Oct 3 16:54 /usr/share/man/man3/MCE::Shared::Scalar.3pm.gz -rw-r--r-- 1 root root 2506 Oct 3 16:54 /usr/share/man/man3/MCE::Shared::Sequence.3pm.gz -rw-r--r-- 1 root root 1240 Oct 3 16:54 /usr/share/man/man3/MCE::Shared::Server.3pm.gz drwxr-xr-x 2 root root 0 Oct 3 16:54 /usr/share/perl5/vendor_perl/MCE -rw-r--r-- 1 root root 26123 Sep 23 08:00 /usr/share/perl5/vendor_perl/MCE/Hobo.pm drwxr-xr-x 2 root root 0 Oct 3 16:54 /usr/share/perl5/vendor_perl/MCE/Shared -rw-r--r-- 1 root root 32395 Sep 23 08:00 /usr/share/perl5/vendor_perl/MCE/Shared.pm -rw-r--r-- 1 root root 24185 Sep 23 08:00 /usr/share/perl5/vendor_perl/MCE/Shared/Array.pm -rw-r--r-- 1 root root 8547 Sep 23 08:00 /usr/share/perl5/vendor_perl/MCE/Shared/Base.pm -rw-r--r-- 1 root root 9928 Sep 23 08:01 /usr/share/perl5/vendor_perl/MCE/Shared/Condvar.pm -rw-r--r-- 1 root root 12273 Sep 23 08:01 /usr/share/perl5/vendor_perl/MCE/Shared/Handle.pm -rw-r--r-- 1 root root 19410 Sep 23 08:01 /usr/share/perl5/vendor_perl/MCE/Shared/Hash.pm -rw-r--r-- 1 root root 56625 Sep 23 08:01 /usr/share/perl5/vendor_perl/MCE/Shared/Minidb.pm -rw-r--r-- 1 root root 39521 Sep 23 08:01 /usr/share/perl5/vendor_perl/MCE/Shared/Ordhash.pm -rw-r--r-- 1 root root 25479 Sep 23 08:01 /usr/share/perl5/vendor_perl/MCE/Shared/Queue.pm -rw-r--r-- 1 root root 5580 Sep 23 08:01 /usr/share/perl5/vendor_perl/MCE/Shared/Scalar.pm -rw-r--r-- 1 root root 9834 Sep 23 08:01 /usr/share/perl5/vendor_perl/MCE/Shared/Sequence.pm -rw-r--r-- 1 root root 61509 Sep 23 08:01 /usr/share/perl5/vendor_perl/MCE/Shared/Server.pm File permissions and layout is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-MCE-Shared-1.805-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(:VERSION) >= 5.10.1 1 perl(bytes) 1 perl(Carp) 1 perl(constant) 1 perl(IO::FDPass) 1 perl(MCE::Mutex) 1 perl(MCE::Shared) 1 perl(MCE::Shared::Array) 1 perl(MCE::Shared::Base) 1 perl(MCE::Shared::Hash) 1 perl(MCE::Shared::Ordhash) 1 perl(MCE::Shared::Server) 1 perl(MCE::Util) 1 perl(overload) 1 perl(Scalar::Util) 1 perl(Socket) 1 perl(strict) 1 perl(threads) 1 perl(threads::shared) 1 perl(Time::HiRes) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Run-require `perl(overloading)' (lib/MCE/Shared/Server.pm:28). FIX: Run-require `perl(Storable) >= 2.04' (lib/MCE/Shared/Minidb.pm:417). FIX: Run-require `perl(Symbol)' (lib/MCE/Shared/Server.pm:306). $ rpm -q --provides -p ../RPMS/noarch/perl-MCE-Shared-1.805-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(MCE::Hobo) = 1.805 1 perl(MCE::Shared) = 1.805 1 perl(MCE::Shared::Array) = 1.805 1 perl(MCE::Shared::Base) = 1.805 1 perl(MCE::Shared::Condvar) = 1.805 1 perl(MCE::Shared::Handle) = 1.805 1 perl(MCE::Shared::Hash) = 1.805 1 perl(MCE::Shared::Minidb) = 1.805 1 perl(MCE::Shared::Object) 1 perl(MCE::Shared::Ordhash) = 1.805 1 perl(MCE::Shared::Ordhash::_href) 1 perl(MCE::Shared::Queue) = 1.805 1 perl(MCE::Shared::Scalar) = 1.805 1 perl(MCE::Shared::Sequence) = 1.805 1 perl(MCE::Shared::Server) = 1.805 1 perl-MCE-Shared = 1.805-1.fc26 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-MCE-Shared-1.805-1.fc26.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F26 (http://koji.fedoraproject.org/koji/taskinfo?taskID=15925335). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items and consider fixing `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx