[Bug 1359402] Review Request: coot - crystallographic macromolecular building toolkit (unretire request )

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1359402



--- Comment #3 from Antonio Trande <anto.trande@xxxxxxxxx> ---
Hi Tim.
First of all:

- Leave a comment about what patches do.

- python(2)-sitelib macro is already defined

- Use python2-devel as BR package

- Use macros instead of hardlinks:
  /usr --> %{_prefix}
  /usr/include/ssm --> %{_includedir}/ssm

- 'rm -rf %{buildroot}' and '%defattr(-,root,root,-)' lines are used on epel5
only.

- doc sub-package isn't noarch

- COPYING is not tagged with %license

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]