[Bug 1379165] Review Request: libslz - StateLess Zip

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1379165



--- Comment #5 from Christoph Junghans <junghans@xxxxxxxxx> ---
(In reply to Dridi Boukelmoune from comment #4)
> > > URL:		http://libslz.org/
> > Seems to be dead?
> 
> Quite the opposite, the web site isn't born yet. Upstream's working on it
> but I put it ahead of time. This is not a widely used project, although it
> will have its use in Fedora and EPEL with haproxy. I plan to open a bug for
> that next.
I would prefer a url, which works now. You can always change in the next
release.

> 
> If that's a problem, I'll change the URL and update once it's ready.
> 
> > > Source:		libslz-1.1.0.tar.gz
> > Fix url
> When I initially submitted this package, archives generated from upstream's
> git-web were non-deterministic and would conflict with our tooling.
> 
> Also, once libslz.org is up, source tarball should be published just like I
> did: a `%{name}-%{version}.tar.gz` archive containing the source tree inside
> a `%{name}-%{version}/` directory.
Actually URL
http://git.1wt.eu/web?p=%{name}.git;a=snapshot;h=v%{version};sf=tgz#/%{name}-%{version}.tar.gz
will work with
%setup -q -n %{name}

> 
> > Are there any consumers of the static libs, which cannot use shared? Otherwise drop.
> 
> Although I'm against bundling in general, I don't see a reason not to ship
> the static lib in the devel subpackage. I actually asked haproxy's author
> (same author) not to expect a static libslz when building against it when we
> were working on making libslz package-able (there used to be no shared lib).
The guideline says "In general, packagers are strongly encouraged not to ship
static libs unless a compelling reason exists.", so drop it if haproxy works
with shared libs.

> 
> I will submit a new spec tomorrow, thanks for reviewing!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]