[Bug 1380420] Review Request: gomtree - Go CLI tool for mtree support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1380420

Jan Chaloupka <jchaloup@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         QA Contact|extras-qa@xxxxxxxxxxxxxxxxx |jchaloup@xxxxxxxxxx



--- Comment #1 from Jan Chaloupka <jchaloup@xxxxxxxxxx> ---
Change 

%gobuild -o bin/%{name} %{import_path}

to

%gobuild -o bin/%{name} %{import_path}/cmd/gomtree

Otherwise rpmlint complains about shebang. Otherwise LGTM:

After the change:

$ rpmlint gomtree-0-0.1.git8c6b32c.fc20.src.rpm
gomtree-0-0.1.git8c6b32c.fc20.x86_64.rpm
gomtree-devel-0-0.1.git8c6b32c.fc20.noarch.rpm
gomtree-unit-test-devel-0-0.1.git8c6b32c.fc20.x86_64.rpm
gomtree.src: W: spelling-error Summary(en_US) mtree -> tree, m tree
gomtree.src: W: spelling-error %description -l en_US mtree -> tree, m tree
gomtree.x86_64: W: spelling-error Summary(en_US) mtree -> tree, m tree
gomtree.x86_64: W: spelling-error %description -l en_US mtree -> tree, m tree
gomtree.x86_64: W: unstripped-binary-or-object /usr/bin/gomtree
gomtree.x86_64: W: no-manual-page-for-binary gomtree
gomtree-devel.noarch: W: spelling-error Summary(en_US) mtree -> tree, m tree
gomtree-devel.noarch: W: spelling-error %description -l en_US mtree -> tree, m
tree
gomtree-devel.noarch: W: spelling-error %description -l en_US github -> git
hub, git-hub, thuggish
gomtree-unit-test-devel.x86_64: W: spelling-error %description -l en_US github
-> git hub, git-hub, thuggish
gomtree-unit-test-devel.x86_64: W: spelling-error %description -l en_US mtree
-> tree, m tree
4 packages and 0 specfiles checked; 0 errors, 11 warnings.

$ gofed lint
W: Incorrect package name gomtree, should be golang-github-vbatts-go-mtree
1 golang specfile checked; 0 errors, 1 warnings.

You can ignore the warning, it is recommendation only.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]