[Bug 1271785] Review Request: nodejs-bcryptjs - bcrypt encryption for NodeJS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1271785

Piotr Popieluch <piotr1212@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review-



--- Comment #4 from Piotr Popieluch <piotr1212@xxxxxxxxx> ---
Seems that the source has multiple licenses, they all need to be specified.

dist dir needs to be installed. Binary as well. Not sure about externs dir.


%build
%nodejs_symlink_deps --check
                     ^^ shouldn't this be --build


%{?nodejs_find_provides_and_requires}
%{!?_licensedir:%global license %doc}
These macros are not needed anymore

tests seem to be included in npm package now. Is the separate download still
needed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]