[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1369708



--- Comment #32 from lo1@xxxxxxxxxx ---
(In reply to yunying.sun from comment #31)
> (In reply to lo1 from comment #30)
> > Changelog needs to be updated every time you make changes:
> > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/
> > Guidelines#Changelogs
> > 
> Thanks for the review Vicky. About change logs, on wiki it says "Every time
> you make changes, that is, whenever you increment the E-V-R of a package,
> add a changelog entry. ". My understanding is only when version and/or
> release is updated, changelog needed. 
> 
> In my case, the target version/release is the package's first release,
> 1.0-beta1, not changed. So I suppose it's better not to log every detailed
> changes which I made to fix issues found during review, otherwise the
> changelog would be long and full of minor details. Is it acceptable?
> 

You're right.  You can do this any number of times, until you actually build
1.0-0.1.beta1 in the buildsystem. By the way, the format of the changelog, in
particular the version-release at the end is not the expected.   You can search
for "%changelog:" in the link:
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#Introduction

> > 
> > 
> > The package failed to build on Fedora 24 (x86_64) as below:
> > 
> Your build failed due to not finding g++. But on koji build server and COPR,
> this package does compile successfully. I did local rpmbuild on my desktop
> with RHEL 7.3 Alpha(No Fedora 24 environment so far). Does Fedora 24 local
> build is mandatory for new package?

No, I dont think the Fedora 24 local build is mandatory.  Sorry, I totally
ignored the koji and copr for some reasons.  To clarify, Koji and Copr build
would be more appropriate and "clean" as my local one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]