[Bug 1379460] Review Request: kompose - Tool to move from `docker-compose` to Kubernetes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1379460

Dusty Mabe <dustymabe@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(dustymabe@redhat. |
                   |com)                        |



--- Comment #7 from Dusty Mabe <dustymabe@xxxxxxxxxx> ---
(In reply to Jan Chaloupka from comment #5)
> > $ rpmlint kompose-0.1.0-0.1.git8227684.fc24.src.rpm kompose-0.1.0-0.1.git8227684.fc24.x86_64.rpm kompose-debuginfo-0.1.0-0.1.git8227684.fc24.x86_64.rpm
> > kompose.src:596: W: macro-in-comment %{buildroot}
> > kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/CONTRIBUTING.md
> > kompose.x86_64: E: script-without-shebang /usr/share/licenses/kompose/LICENSE
> > kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/RELEASE.md
> > kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/README.md
> > kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/code-of-conduct.md
> > kompose.x86_64: W: no-manual-page-for-binary kompose
> > 3 packages and 0 specfiles checked; 1 errors, 6 warnings.
> 
> Permissions of the affected files need to be altered.

I sent a patch upstream for the executable files yesterday, but I can't change
what was released in 0.1.0. I guess I'll add code to the rpm to make them not
executable as well. 

> Man page is optional.

no work to be done here :) 

> The macro should be removed are changed to %%{buildroot}

I changed to comment to not have '%{buildroot}'



latest versions at:
Spec URL: https://dustymabe.fedorapeople.org/kompose-rpm/kompose.spec
SRPM URL:
https://dustymabe.fedorapeople.org/kompose-rpm/kompose-0.1.0-0.1.git8227684.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]