https://bugzilla.redhat.com/show_bug.cgi?id=1379765 Bug ID: 1379765 Summary: Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: alexjnewt@xxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx I currently maintain dolphin in RPMFusion, but since the guidelines have loosened on emulators, I would like to move this into Fedora proper. Spec URL: http://download1.rpmfusion.org/free/fedora/development/rawhide/Everything/source/SRPMS/d/dolphin-emu-5.0-4.fc25.src.rpm SRPM URL: https://pkgs.rpmfusion.org/cgit/free/dolphin-emu.git/plain/dolphin-emu.spec Description: Dolphin is a Gamecube, Wii and Triforce (the arcade machine based on the Gamecube) emulator, which supports full HD video with several enhancements such as compatibility with all PC controllers, turbo speed, networked multiplayer, and more. Most games run perfectly or with minor bugs. Fedora Account System Username: mystro256 Feel free to take a look at the cgit here: https://pkgs.rpmfusion.org/cgit/free/dolphin-emu.git/ Note that the fedora 23 and 24 specs will not include the curl 7.50 fix and acknowledge that I will need to fix the changelog as it incorrectly says "curl 7.5.0". As well, note that I am bundling xxhash for the time being until Bug#1282063 is closed. As soon as that is closed, I will unbundle it from this package. Some notes on the patches: -mbedtls2.3 patch just adds a missing include, which is fixed upstream. I can add a note in the spec if it's deemed necessary. -The "patch/fix" for curl is not applicable to upstream as the code has been reworked, thus I have not reported it upstream. I can also add a note if deemed necessary. -I have reported upstream that the CMake files should add an option to use gtk3 instead of gtk2. Fedora's wxGTK3 is compiled against gtk3 opposed to Ubuntu and Debian, which are compiled against gtk2. Upstream rejected this report as they feel it's not necessary yet. So, the gtk3 patch just replaces the gtk2 CMake logic with a gtk3 equivalent. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx