https://bugzilla.redhat.com/show_bug.cgi?id=1372123 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- non-blocker nit-picks (please fix before submitting any official builds): 5. .spec update lacked %changelog entry 6. %files includes: %{_datadir}/%{name}/* which still leaves the parent dir unowned, better: %{_datadir}/%{name}/ 7. consider not using %{name} macro in %files, it's fragile (ie, if the package name ever changed for any reason, the build would fail). APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx